Repository navigation
Conversation
inducer
approved these changes
Oct 2, 2026
alexfikl
force-pushed
the
fix-get-pde-as-diff-op
branch
from
October 2, 2026 16:33
1a83395 to
2e5ee87
Compare
alexfikl
marked this pull request as draft
October 2, 2026 16:33
alexfikl
marked this pull request as ready for review
October 2, 2026 16:35
alexfikl
force-pushed
the
fix-get-pde-as-diff-op
branch
from
October 2, 2026 16:50
2e5ee87 to
024aaf6
Compare
Collaborator
Author
|
@inducer From a quick grep, it seems like sumpy/sumpy/expansion/local.py Lines 675 to 680 in 5c08eb9 |
alexfikl
force-pushed
the
fix-get-pde-as-diff-op
branch
from
October 9, 2026 14:13
024aaf6 to
6951205
Compare
Owner
|
Yes, let's that make that a |
alexfikl
force-pushed
the
fix-get-pde-as-diff-op
branch
from
October 9, 2026 14:56
6951205 to
f666c56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in #279 because the Fourier symbol was derived from the expression returned by
get_pde_as_diff_op, but the kernel itself (e.g. the global scaling) used theSpatialConstantnaming and conflicted (i.e. could not be simplified).This seems like a good idea to keep it consistent?